[Gecko Bug 1990582] Fix view transitions with table as the root element frame.#55098
Merged
moz-wptsync-bot merged 1 commit intomasterfrom Sep 27, 2025
Merged
[Gecko Bug 1990582] Fix view transitions with table as the root element frame.#55098moz-wptsync-bot merged 1 commit intomasterfrom
moz-wptsync-bot merged 1 commit intomasterfrom
Conversation
Use the root element style frame (not primary frame) for style checks in the root scroll frame. This only makes a difference for display: table on the root, and is needed because a lot of the checks that we do for filters, etc on the root check IsRootElementStyleFrame(), so the checks are inconsistent otherwise. Differential Revision: https://phabricator.services.mozilla.com/D266320 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1990582 gecko-commit: e7245cd02538de3c13f96ce93b50db1d6d79b1cc gecko-reviewers: jwatt
wpt-pr-bot
approved these changes
Sep 26, 2025
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Firefox project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the root element style frame (not primary frame) for style checks in
the root scroll frame.
This only makes a difference for display: table on the root, and is
needed because a lot of the checks that we do for filters, etc on the
root check IsRootElementStyleFrame(), so the checks are inconsistent
otherwise.
Differential Revision: https://phabricator.services.mozilla.com/D266320
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1990582
gecko-commit: e7245cd02538de3c13f96ce93b50db1d6d79b1cc
gecko-reviewers: jwatt